Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: WW 2.2.1
    • Fix Version/s: WW 2.2.2
    • Component/s: Build Management
    • Labels:
      None

      Description

      Using xhtml template I had found different issues:

      1. I cannot change table class or style for items table.
      My proposition:
      in xhtml/form.ftl change "<table class="wwFormTable">"
      to
      <table class="$

      {parameters.cssClass?default('wwFormTable')?html}

      "
      <#if parameters.cssStyle?exists>
      style="$

      {parameters.cssStyle?html}

      "<#rt/>
      </#if>
      >

      2. I cannot change position of * for required fields to right from label
      3. I cannot change align of TD for label (now is top and right)

      4. Setting of class and style for form in simple/form.ftl is fruitless - words of designer in my company

      5. In simple/label.ftl setting of class occurs twice.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        2d 31m 1 Rainer Hermanns 03/Mar/06 17:28
        In Progress In Progress Closed Closed
        13d 19h 19m 1 Rainer Hermanns 17/Mar/06 12:47
        Jeff Turner made changes -
        Project Import Mon Feb 01 01:17:42 UTC 2010 [ 1264987062082 ]
        Antonio Petrelli made changes -
        Workflow Struts - editable closed status (temporary) [ 48064 ] Struts - editable closed status [ 51316 ]
        Antonio Petrelli made changes -
        Workflow Struts - editable closed status [ 43650 ] Struts - editable closed status (temporary) [ 48064 ]
        Jeff Turner made changes -
        Workflow Struts [ 40019 ] Struts - editable closed status [ 43650 ]
        Don Brown made changes -
        Workflow jira [ 35045 ] Struts [ 40019 ]
        Rainer Hermanns made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Hide
        Rainer Hermanns added a comment -

        Fixed in CVS HEAD.
        Thanks for the patch

        Show
        Rainer Hermanns added a comment - Fixed in CVS HEAD. Thanks for the patch
        Hide
        Rainer Hermanns added a comment -

        1 + 5 are commited...
        2 + 3 still need some thoughts.. Will look into this during the weekend
        4 is a no fix, if you ask me...

        Show
        Rainer Hermanns added a comment - 1 + 5 are commited... 2 + 3 still need some thoughts.. Will look into this during the weekend 4 is a no fix, if you ask me...
        Rainer Hermanns made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Rainer Hermanns added a comment -

        Regarding 4)

        The form html attribute support the coreattributes of HTML tags, so class and style are supported as well...

        From HTML 4.0.1 DTD:

        <!-================ Forms ===============================================->
        <!ELEMENT FORM - - (%block;|SCRIPT)+ -(FORM) – interactive form -->
        <!ATTLIST FORM
        %attrs; – %coreattrs, %i18n, %events –
        action %URI; #REQUIRED – server-side form handler –
        method (GET|POST) GET – HTTP method used to submit the form--
        enctype %ContentType; "application/x-www-form-urlencoded"
        accept %ContentTypes; #IMPLIED – list of MIME types for file upload –
        name CDATA #IMPLIED – name of form for scripting –
        onsubmit %Script; #IMPLIED – the form was submitted –
        onreset %Script; #IMPLIED – the form was reset –
        accept-charset %Charsets; #IMPLIED – list of supported charsets –
        >

        <!ENTITY % coreattrs
        "id ID #IMPLIED – document-wide unique id –
        class CDATA #IMPLIED – space-separated list of classes –
        style %StyleSheet; #IMPLIED – associated style info –
        title %Text; #IMPLIED – advisory title --"
        >

        Show
        Rainer Hermanns added a comment - Regarding 4) The form html attribute support the coreattributes of HTML tags, so class and style are supported as well... From HTML 4.0.1 DTD: <!- ================ Forms =============================================== -> <!ELEMENT FORM - - (%block;|SCRIPT)+ -(FORM) – interactive form --> <!ATTLIST FORM %attrs; – %coreattrs, %i18n, %events – action %URI; #REQUIRED – server-side form handler – method (GET|POST) GET – HTTP method used to submit the form-- enctype %ContentType; "application/x-www-form-urlencoded" accept %ContentTypes; #IMPLIED – list of MIME types for file upload – name CDATA #IMPLIED – name of form for scripting – onsubmit %Script; #IMPLIED – the form was submitted – onreset %Script; #IMPLIED – the form was reset – accept-charset %Charsets; #IMPLIED – list of supported charsets – > <!ENTITY % coreattrs "id ID #IMPLIED – document-wide unique id – class CDATA #IMPLIED – space-separated list of classes – style %StyleSheet; #IMPLIED – associated style info – title %Text; #IMPLIED – advisory title --" >
        Hide
        Schava Eugene added a comment -

        and I think that WW needs in mechanizm for configuring builtin themes. For example - image for tooltip. And other usefull things

        Show
        Schava Eugene added a comment - and I think that WW needs in mechanizm for configuring builtin themes. For example - image for tooltip. And other usefull things
        Hide
        Schava Eugene added a comment -

        My solutions:

        1.
        Update xhtml/form.ftl:

        <#include "/$

        {parameters.templateDir}/xhtml/form-validate.ftl" />
        <#include "/${parameters.templateDir}

        /simple/form.ftl" />
        <table class="$

        {parameters.cssClass?default('wwFormTable')?html}

        "<#rt/>
        <#if parameters.cssStyle?exists>
        style="$

        {parameters.cssStyle?html}"<#rt/>
        </#if>
        >

        2 and 3.
        Patch for xhtml/controlheader-core.ftl:

        — 1.ftl 2006-03-03 12:52:20.000000000 +0200
        +++ temp/make/webwork/src/java/template/xhtml/controlheader-core.ftl 2006-03-03 12:29:13.000000000 +0200
        @@ -24,7 +24,7 @@
        <#if parameters.labelposition?default("") == 'top'>
        <td align="left" valign="top" colspan="2"><#rt/>
        <#else>
        - <td align="right" valign="top"><#rt/>
        + <td class="tdLabel"><#rt/>
        </#if>
        <#if parameters.label?exists>
        <label <#t/>
        @@ -37,10 +37,14 @@
        class="label"<#t/>
        </#if>
        ><#t/>
        -<#if parameters.required?default(false)>
        +<#if parameters.required?default(false) && parameters.requiredPosition?default("") != 'right'>
        <span class="required">*</span><#t/>
        </#if>
        -${parameters.label?html}:<#t/>
        +${parameters.label?html}<#t/>
        +<#if parameters.required?default(false) && parameters.requiredPosition?default("") == 'right'>
        + <span class="required">*</span><#t/>
        +</#if>
        +:<#t/>
        <#include "/${parameters.templateDir}/xhtml/tooltip.ftl" />
        </label><#t/>
        </#if>

        And add line to xhtml/style.css:
        .tdLabel {text-align:right; vertical-align:top; }

        But I dont know how to set parameters.requiredPosition globally to all aplication ? Using webwork.properties?
        Key like webwork.ui.theme.xhtml.requiredPosition ?

        4. Remove from simple/form.ftl lines:
        <#if parameters.cssClass?exists>
        class="${parameters.cssClass?html}"<#rt/>
        </#if>
        <#if parameters.cssStyle?exists>
        style="${parameters.cssStyle?html}

        "<#rt/>
        </#if>

        5. Remove from simple/label.ftl second occur of:
        <#if parameters.cssClass?exists>
        class="$

        {parameters.cssClass?html}

        "<#rt/>
        </#if>

        Show
        Schava Eugene added a comment - My solutions: 1. Update xhtml/form.ftl: <#include "/$ {parameters.templateDir}/xhtml/form-validate.ftl" /> <#include "/${parameters.templateDir} /simple/form.ftl" /> <table class="$ {parameters.cssClass?default('wwFormTable')?html} "<#rt/> <#if parameters.cssStyle?exists> style="$ {parameters.cssStyle?html}"<#rt/> </#if> > 2 and 3. Patch for xhtml/controlheader-core.ftl: — 1.ftl 2006-03-03 12:52:20.000000000 +0200 +++ temp/make/webwork/src/java/template/xhtml/controlheader-core.ftl 2006-03-03 12:29:13.000000000 +0200 @@ -24,7 +24,7 @@ <#if parameters.labelposition?default("") == 'top'> <td align="left" valign="top" colspan="2"><#rt/> <#else> - <td align="right" valign="top"><#rt/> + <td class="tdLabel"><#rt/> </#if> <#if parameters.label?exists> <label <#t/> @@ -37,10 +37,14 @@ class="label"<#t/> </#if> ><#t/> -<#if parameters.required?default(false)> +<#if parameters.required?default(false) && parameters.requiredPosition?default("") != 'right'> <span class="required">*</span><#t/> </#if> -${parameters.label?html}:<#t/> +${parameters.label?html}<#t/> +<#if parameters.required?default(false) && parameters.requiredPosition?default("") == 'right'> + <span class="required">*</span><#t/> +</#if> +:<#t/> <#include "/${parameters.templateDir}/xhtml/tooltip.ftl" /> </label><#t/> </#if> And add line to xhtml/style.css: .tdLabel {text-align:right; vertical-align:top; } But I dont know how to set parameters.requiredPosition globally to all aplication ? Using webwork.properties? Key like webwork.ui.theme.xhtml.requiredPosition ? 4. Remove from simple/form.ftl lines: <#if parameters.cssClass?exists> class="${parameters.cssClass?html}"<#rt/> </#if> <#if parameters.cssStyle?exists> style="${parameters.cssStyle?html} "<#rt/> </#if> 5. Remove from simple/label.ftl second occur of: <#if parameters.cssClass?exists> class="$ {parameters.cssClass?html} "<#rt/> </#if>
        Rainer Hermanns made changes -
        Field Original Value New Value
        Affects Version/s 2.2.1 [ 21591 ]
        Fix Version/s 2.2.2 [ 21600 ]
        Assignee Rainer Hermanns [ rainerh ]
        Schava Eugene created issue -

          People

          • Assignee:
            Rainer Hermanns
            Reporter:
            Schava Eugene
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development