Uploaded image for project: 'WSS4J'
  1. WSS4J
  2. WSS-642

Use LinkedHashSet instead of TreeSet within getInclusivePrefixes

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.2.3
    • Component/s: WSS4J Core
    • Labels:
      None

      Description

      WSS-626 changed the implementation of the SignatureUtils#getInclusivePrefixes method to use a Set instead of a List. This change makes sense, however it changes the order that the prefixes had historically been returned by this method. A client of ours is having a problem with the new ordering. Although this is certainly a bug on their end, it seems reasonable to replicate the previous behavior of this method as closely as possible while still fixing the bug reported in the issue.

      I'd like to suggest using a LinkedHashSet instead of a TreeSet as the Set implementation in this method. The LHS preserves the insertion order as the order the elements are returned in. This should make this method behave as closely as possible prior to the 2.2.2 release of WSS4J.

        Attachments

          Activity

            People

            • Assignee:
              coheigea Colm O hEigeartaigh
              Reporter:
              jjathman Joseph Athman
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: