Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5.4
    • Component/s: None
    • Labels:
      None

      Description

      WSHandler#getPassword tries to get a password by:

      a) Trying to construct a password callback
      b) Trying to get a password callback object from the Message Context
      c) Trying to get the password directly from the Message Context, i.e. delegating this to a subclass of WSHandler

      There are some problems with how the current code handles option (c). In particular, the action to be performed, as well as the username, are not preserved in the WSPasswordCallback object that gets returned. This in turn leads to problems with the UsernameTokenAction, which obtains the username from the WSPasswordCallback.

      See attached for a patch for this problem. In addition, I added some fairly extensive unit testing of the getPassword method.

      1. wss4j_get_password.patch
        15 kB
        Colm O hEigeartaigh

        Activity

        Hide
        Fred Dushin added a comment -

        Bulk change of "Fix Version" for all issues fixed or closed for 1.5.4

        Show
        Fred Dushin added a comment - Bulk change of "Fix Version" for all issues fixed or closed for 1.5.4
        Hide
        Fred Dushin added a comment -

        Applied Colm's fix.

        This change should be noncontroversial – it's a simple refactor of the creation of the WSPasswordCallback object, and does not result in any change in behavior (except for the addition of information to the callback instance created)

        Show
        Fred Dushin added a comment - Applied Colm's fix. This change should be noncontroversial – it's a simple refactor of the creation of the WSPasswordCallback object, and does not result in any change in behavior (except for the addition of information to the callback instance created)

          People

          • Assignee:
            Fred Dushin
            Reporter:
            Colm O hEigeartaigh
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development