Wookie
  1. Wookie
  2. WOOKIE-332

wookie php connector relies on file_get_contents which is sometimes disabled

    Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 0.9.0, 0.9.1, 0.9.2, 0.10.0, 0.11.0, 0.12.0, 0.13.0
    • Fix Version/s: 2.0.0
    • Component/s: Connection Framework
    • Labels:
    • Environment:
      GNU/Linux 2.6.32-220.2.1.el6.x86_64
      php5
      elgg platform

      Description

      Since a few weeks ago our server admin disabled php's function
      file_get_contents (for security reasons) which resulted for our elgg
      plugin not to work.

      I did a quick goole search and found that disabling file_get_contents
      is quite usual in virtual servers setups - dreamhost for example has
      it locked.
      In the other hand curl might not be enabled as well but i guess is
      more likely for file_get_contents to be unavailable instead of curl

        Activity

        Hide
        Lucas Anastasiou added a comment -

        This is a quick fix
        Just touched the do_request function
        Tested it for GET/POST not for DELETE/PUT

        Show
        Lucas Anastasiou added a comment - This is a quick fix Just touched the do_request function Tested it for GET/POST not for DELETE/PUT
        Hide
        Scott Wilson added a comment -

        Thanks for the patch, Lucas - this is definitely something I've seen with a few systems (I think Elgg also locks down get_contents). However I'm not familiar enough with PHP and the PHP Connector to evaluate the patch. Maybe Raido and/or Kris could take alook at it?

        Show
        Scott Wilson added a comment - Thanks for the patch, Lucas - this is definitely something I've seen with a few systems (I think Elgg also locks down get_contents). However I'm not familiar enough with PHP and the PHP Connector to evaluate the patch. Maybe Raido and/or Kris could take alook at it?
        Hide
        Kris Popat added a comment -

        Hi Lucas,

        Yes, I'll take a look at it. Will try to get back on this tomorrow.

        Kris

        Show
        Kris Popat added a comment - Hi Lucas, Yes, I'll take a look at it. Will try to get back on this tomorrow. Kris
        Hide
        Kris Popat added a comment -

        Hi Lucas,

        Sorry it's taken me a little while to look at this.

        I'm having a little difficulty applying the patch to check it. Would it be possible to recreate the patch file without the full paths?

        Thanks

        Kris

        Show
        Kris Popat added a comment - Hi Lucas, Sorry it's taken me a little while to look at this. I'm having a little difficulty applying the patch to check it. Would it be possible to recreate the patch file without the full paths? Thanks Kris
        Hide
        Kris Popat added a comment -

        I have made some modifications to this, but they need feedback before committing. As this is not a blocker for release I'll move the issue to 10.1

        Show
        Kris Popat added a comment - I have made some modifications to this, but they need feedback before committing. As this is not a blocker for release I'll move the issue to 10.1
        Hide
        Scott Wilson added a comment -

        Is there anything else needed before the patch can be applied and the issue closed?

        Show
        Scott Wilson added a comment - Is there anything else needed before the patch can be applied and the issue closed?
        Hide
        Paul Sharples added a comment -

        In progress, but not yet finished, moving down.

        Show
        Paul Sharples added a comment - In progress, but not yet finished, moving down.
        Hide
        Paul Sharples added a comment -

        Moving to next version

        Show
        Paul Sharples added a comment - Moving to next version
        Hide
        Scott Wilson added a comment -

        Defer to next release

        Show
        Scott Wilson added a comment - Defer to next release

          People

          • Assignee:
            Kris Popat
            Reporter:
            Lucas Anastasiou
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Development