[WINK-96] proposal: enhance search for matched resources by decoding URI

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.1
• Fix Version/s: 0.1
• Component/s: Server
• Patch Info: Patch Available
• Assignee: Martin Snitkovsky
• Reporter: Michael Rheinheimer
• Created: 14/Jul/09 19:25
• Updated: 17/Jul/09 09:00
• Resolved: 15/Jul/09 12:52

Description

The current "search" for matching root resources in FindRootResourceHandler.handleRequest does not take into account an encoded URL path. I wasn't sure where or how to test for this. There is already a test at UriInfoImplTest.testUriInfo that has an encoded URI path segment, but I think the MockRequestConstructor or MockHttpServletRequest is already decoding it prior to sending it. See attached patch for the proposed fix. I could use a little pointer as to where to put the test in the unittests.

I have a test for this in a forthcoming integration test Jira. It looks something like this:

HttpClient client = new HttpClient();
GetMethod getMethod = new GetMethod(getBaseURI()
+ "/%75riinfo");
client.executeMethod(getMethod);
assertEquals(200, getMethod.getStatusCode());

Without the attached patch fix, I get a 404. With the attached patch, this test passes.

Issue Links

• blocks: WINK-97 new integration tests: context, uriinfo, etc