Wink
  1. Wink
  2. WINK-364

ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be thread safe and support connection pooling

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: None
    • Component/s: Client
    • Labels:
    • Patch Info:
      Patch Available

      Description

      I found the following issues when using ApacheHttpClientConnectionHandler:
      a.) openConnection() should be synchronized. It need not be synchronized if the httpClient was passed in, but that is typically not the case
      b.) ApacheHttpClientConnectionHandler should be thread safe and support connection pooling
      c.) Deprecated method usage
      d.) Request not properly aborted when exceptions are thrown by httpClient#execute()

      I will attach a patch. Please review and apply the patch. Thanks

        Activity

        Seshu Pasam created issue -
        Seshu Pasam made changes -
        Field Original Value New Value
        Attachment wink-client-apache-httpclient.diff [ 12520449 ]
        Seshu Pasam made changes -
        Summary ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be thread pool and support connection pooling ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be thread safe and support connection pooling
        Raymond Feng made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Seshu Pasam
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development