[WICKET-7074] [AJAX] malformed XML is produced if an error is produced during AJAX rendering and a redirect is issued

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 10.0.0-M1, 9.15.0
• Fix Version/s: 10.0.0-M2, 9.16.0
• Assignee: Ernesto Reinaldo Barreiro
• Reporter: Ernesto Reinaldo Barreiro
• Created: 18/Sep/23 21:07
• Updated: 29/Nov/23 07:22
• Resolved: 24/Sep/23 15:00

Description

In AjaxRequestHandler in case there are no filters defined AjaxUpdate written directly to response. See below

 

 

// code placeholder

if (filters == null || filters.isEmpty())
{
    update.writeTo(response, encoding);
}
else
{
    final StringResponse bodyResponse = new StringResponse();
    update.writeTo(bodyResponse, encoding);
    CharSequence filteredResponse = invokeResponseFilters(bodyResponse, filters);
    response.write(filteredResponse);
} 

 

In case a "dynamic" error is produced and we use exception mapper to redirect to an error page then generated response XML is of the form

 

// code placeholder

<?xml version="1.0" encoding="UTF-8"?><ajax-response><ajax-response><redirect><![CDATA[./internalError?4]]></redirect></ajax-response>

which is malfomed and this causes redirect to be broken. 

 

Issue Links

• links to: GitHub Pull Request #655
• links to: GitHub Pull Request #656
• links to: GitHub Pull Request #658