[WICKET-6999] Missing Export-Package of packages with "internal" in name

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 8.14.0, 9.11.0
• Fix Version/s: 10.0.0-M1, 9.12.0
• Component/s: wicket
• Assignee: Unassigned
• Reporter: Daniel Stoch
• Created: 01/Sep/22 10:16
• Updated: 08/Feb/23 19:14
• Resolved: 10/Oct/22 18:38

Description

Some packages in Wicket have "internal" word in its name, eg.:
org.apache.wicket.markup.html.internal
But they are a part of public API (eg. HtmlHeaderContainer). These packages should be exported in MANIFEST.MF file in Export-Package section as in Wicket 6.x/7.x.

I think something was broken in MANIFEST.MF generation, maybe some generator plugin (org.apache.felix.maven-bundle-plugin) configuration or version change? Packages with "internal" can be by default excluded from Export-Package section. But it is not a case in Wicket library.
Here is excerpt from "Apache Felix Maven Bundle Plugin" documentation:

<Export-Package> is now assumed to be the set of packages in your local Java sources, excluding the default package '.' and any packages containing 'impl' or 'internal'. (before version 2 of the bundleplugin it was based on the symbolic name)

Issue Links

• relates to: WICKET-6958 Allow to use Slf4j 1.7.x in OSGi runtime
• relates to: WICKET-7021 Additional OSGi import fixes
• links to: GitHub Pull Request #540