[WICKET-6982] Unnecessary initialization of stateful pages in ListenerRequestHandler

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 9.10.0
• Fix Version/s: 10.0.0-M1, 9.12.0
• Component/s: wicket-core
• Assignee: Thomas Heigl
• Reporter: Thomas Heigl
• Created: 16/May/22 09:56
• Updated: 13/Jul/22 09:44
• Resolved: 16/May/22 20:43

Description

ListenerRequestHandler currently forces initialization of pages. For already initialized stateful pages, this traverses the entire component hierarchy. For large pages, this can be a costly operation.

My profiler shows a significant amount of CPU load coming from these unnecessary traversals:

Forcing page initialization was originally introduced in WICKET-4116 in this commit to fix an issue with expired pages and checking for statelessness.

In WICKET-5083, this commit added the same forced initialization directly to Page.isPageStateless().

I think we can get rid of the initialization in ListenerRequestHandler and rely on the conditional logic in Page.isPageStateless to trigger initialization if necessary.

 

 

Issue Links

• links to: GitHub Pull Request #526