[WICKET-6970] Unnecessary string building in AssociatedMarkupSourcingStrategy

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 10.0.0-M1, 9.9.0
• Fix Version/s: 10.0.0-M1, 9.10.0
• Component/s: wicket-core
• Assignee: Emond Papegaaij
• Reporter: Emond Papegaaij
• Created: 08/Apr/22 20:30
• Updated: 12/Apr/22 00:03
• Resolved: 11/Apr/22 08:41

Description

AssociatedMarkupSourcingStrategy.renderAssociatedMarkup builds a string just for an exception message. The method MarkupContainer.renderAssociatedMarkup is only called from this single location and is not really meant for public consumption. I suggest we inline the message and only build it when it's actually needed. For 9.x we must keep the parameter, but we can call it with null.