Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-6970

Unnecessary string building in AssociatedMarkupSourcingStrategy

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 10.0.0, 9.9.0
    • 10.0.0, 9.10.0
    • wicket-core
    • None

    Description

      AssociatedMarkupSourcingStrategy.renderAssociatedMarkup builds a string just for an exception message. The method MarkupContainer.renderAssociatedMarkup is only called from this single location and is not really meant for public consumption. I suggest we inline the message and only build it when it's actually needed. For 9.x we must keep the parameter, but we can call it with null.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            papegaaij Emond Papegaaij
            papegaaij Emond Papegaaij
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment