[WICKET-6952] Performance improvements for Strings.isEmpty

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 9.7.0
• Fix Version/s: 10.0.0-M1, 9.8.0
• Component/s: wicket-core
• Assignee: Thomas Heigl
• Reporter: Thomas Heigl
• Created: 01/Feb/22 21:18
• Updated: 02/Feb/22 21:05
• Resolved: 02/Feb/22 21:05

Description

Strings.isEmpty is one of the most called methods in our application and consistently shows up as hot in our production profiler.

Two simple performance optimizations can be tried:

• Overload the method with a String parameter, to help the JIT compiler with it's decision to inline the method
• Avoid calling String.trim if the first character isn't whitespace

See https://github.com/apache/wicket/pull/497.

Issue Links

• links to: GitHub Pull Request #497