[WICKET-6890] Render debug setting 'outputMarkupContainerClassName` as an attribute

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 10.0.0-M1
• Component/s: wicket-core
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Martin Tzvetanov Grigorov
• Created: 28/May/21 09:07
• Updated: 04/Mar/24 19:04
• Resolved: 28/May/21 09:22

Description

As discussed at https://markmail.org/message/uoxxlnbz56ex7vuk when org.apache.wicket.settings.DebugSettings#isOutputMarkupContainerClassName() returns true then the MarkupContainer class name should be rendered as an attribute of the component tag instead of as an HTML comment because an HTML comment may break a CSS rule, e.g. by appearing between two sibling HTML elements

p + p {color: red;} 

 

The CSS rule above will change the text color of any paragraph that follows another paragraph. But if an HTML comment appears between them then the rule won't apply.

Issue Links

• links to: GitHub Pull Request #781