Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-6778

Clearing MarkupContainer.REMOVALS_KEY is expensive

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 9.0.0-M5
    • Fix Version/s: 9.0.0-M6
    • Component/s: wicket-core
    • Labels:
      None

      Description

      The REMOVALS_KEY metadata on MarkupContainer is cleared on every request. This is an expensive operation and often unnecessary. By putting this operation behind a request flag, it can often be avoided.

      An alternative approach is to check if the key is set (via getMetaData(REMOVALS_KEY)) and only clear it when it's set. This is faster than current master, but slower than using a flag.

        Attachments

          Activity

            People

            • Assignee:
              papegaaij Emond Papegaaij
              Reporter:
              papegaaij Emond Papegaaij
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: