[WICKET-6778] Clearing MarkupContainer.REMOVALS_KEY is expensive

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 9.0.0-M5
• Fix Version/s: 9.0.0
• Component/s: wicket-core
• Assignee: Emond Papegaaij
• Reporter: Emond Papegaaij
• Created: 04/May/20 20:13
• Updated: 05/May/20 18:04
• Resolved: 05/May/20 18:04

Description

The REMOVALS_KEY metadata on MarkupContainer is cleared on every request. This is an expensive operation and often unnecessary. By putting this operation behind a request flag, it can often be avoided.

An alternative approach is to check if the key is set (via getMetaData(REMOVALS_KEY)) and only clear it when it's set. This is faster than current master, but slower than using a flag.