[WICKET-6776] Cache Urls returned from ServletWebRequest

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 8.7.0, 9.0.0-M5
• Component/s: wicket-core
• Assignee: Unassigned
• Reporter: Thomas Heigl
• Created: 30/Apr/20 07:20
• Updated: 21/May/20 13:19

Description

Profiling in production showed that ServletWebRequest.getUrl() and ServletWebRequest.getClientUrl() are called many times during request processing and allocate a lot of objects.

Each call to ServletWebRequest.getUrl() creates a new Url object that internally creates two new ArrayLists.

ServletWebRequest.getClientUrl() creates a new URL and involves a lot of complex parsing logic.

Both methods are invoked during request mapping. We have about 350 registered mappers, so these methods are called at least 350 times on each request.

Both values should be cached.

Issue Links

• is related to: WICKET-6709 Cache the value of WebRequest#isAjax()