[WICKET-6765] WS broadcast of ClosedMessage rewrites touchedPages by its single page

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 7.7.0, 8.7.0
• Component/s: wicket-native-websocket
• Environment: Java 8, Tomcat 9.0.27 and Jetty 9.4.18, Firefox 75.0
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Jan Cerny
• Created: 09/Apr/20 16:16
• Updated: 19/Jul/21 17:35

Description

That causes a lost of instances of newly touched pages (within PageStoreManager). For quite specific scenario that could have visible impact.

Conditions to be fulfilled to see effect:

1. calling setResponsePage(new NewResponsePage(customParams)) within AjaxLink (Link works)
   • this instance of passed page is not used for rendering (customParams are lost) - page is overridden by AbstractWebSocketProcessor.onClose() - within PersistentRequestAdapter.storeTouchedPages()
2. RenderStrategy.REDIRECT_TO_RENDER must be applied
   • otherwise it is rendered before AbstractWebSocketProcessor.onClose()
3. VoidPageManagerProvider must be used - setPageManagerProvider(new VoidPageManagerProvider(this));
   • otherwise it is saved and loaded within PageManager not only in session

I'm attaching test application with example of losing page instance (and passed arguments). Important lines marked NOT WORKING in java and html files.

 

Issue Links

• is a child of: WICKET-6380 AbstractWebSocketProcessor.onClose() rewrites possibly wider processed and stored touchedPages to only Page itself
• is cloned by: WICKET-6905 CLONE - WS broadcast of ClosedMessage rewrites touchedPages by its single page