[WICKET-6673] PriorityHeaderItem ordering is wrong for siblings

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 9.0.0
• Fix Version/s: 9.0.0-M3
• Component/s: wicket
• Assignee: Sven Meier
• Reporter: Sven Meier
• Created: 05/Jun/19 07:29
• Updated: 10/Aug/20 15:32
• Resolved: 11/Sep/19 17:28

Description

PriorityHeaderItems allows parents to move their header items infront of those of their children (parent-first instead of child-first).

But the current implemention sorts PriorityHeaderItems of siblings in reverse order, e.g. having a component hierarchy as follows:

Component A
+- Component AA
+- Component AB

... the PriorityHeaderItems of all these components are sorted as:

- PriorityHeaderItem of A
- PriorityHeaderItem of AB
- PriorityHeaderItem of AA

Why should the PriorityHeaderItem of component AB be before that of AA? This isn't parent-first, it is reverse-order.

IMHO a more suitable ordering would be "parent-first-preserving-siblings":

- PriorityHeaderItem of A
- PriorityHeaderItem of AA
- PriorityHeaderItem of AB

Issue Links

• mentioned in: Page Loading...