Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-6543

onConfigure() Javadoc claims Overrides must call super, but there is no check to enforce it

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 8.0.0-M8
    • 8.0.0
    • None
    • None

    Description

      https://github.com/apache/wicket/blob/9e42a9548adb0da540e4e87d491f5824e778537e/wicket-core/src/main/java/org/apache/wicket/Component.java#L795 claims that: 

      Overrides must call {@code super.onConfigure()}, usually before any other code

      However Component#onConfigure() does not set a flag (like onInitialize() does) nor does configure() check that its own onConfigure() gets called.

      As user of the framework, I would expect consistent behavior between onConfigure() and onInitialize().

      It might be a good idea to fix this before Wicket 8.0.0, as changing this behavior is a breaking change.

      Attachments

        Issue Links

          Activity

            People

              svenmeier Sven Meier
              keesvandieren Kees van Dieren
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: