[WICKET-6501] DefaultPageManagerProvider does not honour StoreSettings.setAsynchronous(false)

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 8.0.0-M8
• Fix Version/s: 7.10.0, 6.29.0, 8.0.0-M9
• Component/s: wicket
• Assignee: Maxim Solodovnik
• Reporter: Greg Johnson
• Created: 27/Nov/17 09:51
• Updated: 06/Feb/18 12:52
• Resolved: 28/Nov/17 03:49

Description

StoreSettings.setAsynchronous(false) does not prevent pageStore from being wrapped with AsynchronousPageStore

DefaultPageManagerProvider.java:
if (pageStore.canBeAsynchronous())

{ pageStore = new AsynchronousPageStore(pageStore, capacity); }

Suggest:
if (pageStore.canBeAsynchronous() && storeSettings.isAsynchronous()){ pageStore = new AsynchronousPageStore(pageStore, capacity); }

Issue Links

• links to: GitHub Pull Request #248