Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 7.7.0
    • Fix Version/s: 8.0.0-M7
    • Component/s: wicket
    • Labels:
      None

      Description

      It concerns the reading of PageParameters. They all use the StringValue constructor without passing the Session locale.
      The StringValue will in turn use the systems locale.

      So when I retrieve a _en formatted number (1.000) from my GET-Params, I get a wrong number (1) because my Server runs on a _de machine where a dot is a decimal delimeter.

      I can work around that by again creating a StringValue based on my previous StringValue, but with passing the Session locale.

      Shouldn't it pass the session's locale in first place?

      See here for the PageParameter implementation and here for the StringValue implementation.

      See also:
      http://apache-wicket.1842946.n4.nabble.com/Localization-of-PageParameters-td4678221.html

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7697741252d9542a9686f8d745a4e8c19465be32 in wicket's branch refs/heads/WICKET-6419 from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=7697741 ]

          WICKET-6419 Localization of PageParameters

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7697741252d9542a9686f8d745a4e8c19465be32 in wicket's branch refs/heads/ WICKET-6419 from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=7697741 ] WICKET-6419 Localization of PageParameters
          Hide
          mgrigorov Martin Grigorov added a comment -

          This is what I suggest as an improvement for this ticket.
          The old behavior is preserved and the new functionality is opt-in, i.e. the application developer should override org.apache.wicket.request.mapper.AbstractMapper#resolveLocale() as I did in org.apache.wicket.core.request.mapper.LocaleAwarePageParametersTest#newApplication() to get the user's locale.

          Show
          mgrigorov Martin Grigorov added a comment - This is what I suggest as an improvement for this ticket. The old behavior is preserved and the new functionality is opt-in, i.e. the application developer should override org.apache.wicket.request.mapper.AbstractMapper#resolveLocale() as I did in org.apache.wicket.core.request.mapper.LocaleAwarePageParametersTest#newApplication() to get the user's locale.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e75cb25605ac64e4b2f6bc149f7f2e1243f824cb in wicket's branch refs/heads/WICKET-6419 from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=e75cb25 ]

          WICKET-6419 Localization of PageParameters

          Explicitly set the default locale to ENGLISH so that the test doesn't fail on developer machines with DE locale.

          Show
          jira-bot ASF subversion and git services added a comment - Commit e75cb25605ac64e4b2f6bc149f7f2e1243f824cb in wicket's branch refs/heads/ WICKET-6419 from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=e75cb25 ] WICKET-6419 Localization of PageParameters Explicitly set the default locale to ENGLISH so that the test doesn't fail on developer machines with DE locale.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 77dee2bbd513db2ee89eb4882e02142f1fa619cd in wicket's branch refs/heads/WICKET-6419 from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=77dee2b ]

          WICKET-6419 Localization of PageParameters

          Add some checks to be on the safe side.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 77dee2bbd513db2ee89eb4882e02142f1fa619cd in wicket's branch refs/heads/ WICKET-6419 from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=77dee2b ] WICKET-6419 Localization of PageParameters Add some checks to be on the safe side.
          Hide
          bitstorm Andrea Del Bene added a comment -

          +1 looks good to me

          Show
          bitstorm Andrea Del Bene added a comment - +1 looks good to me
          Hide
          solomax Maxim Solodovnik added a comment -

          +1

          Show
          solomax Maxim Solodovnik added a comment - +1
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7697741252d9542a9686f8d745a4e8c19465be32 in wicket's branch refs/heads/master from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=7697741 ]

          WICKET-6419 Localization of PageParameters

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7697741252d9542a9686f8d745a4e8c19465be32 in wicket's branch refs/heads/master from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=7697741 ] WICKET-6419 Localization of PageParameters
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e75cb25605ac64e4b2f6bc149f7f2e1243f824cb in wicket's branch refs/heads/master from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=e75cb25 ]

          WICKET-6419 Localization of PageParameters

          Explicitly set the default locale to ENGLISH so that the test doesn't fail on developer machines with DE locale.

          Show
          jira-bot ASF subversion and git services added a comment - Commit e75cb25605ac64e4b2f6bc149f7f2e1243f824cb in wicket's branch refs/heads/master from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=e75cb25 ] WICKET-6419 Localization of PageParameters Explicitly set the default locale to ENGLISH so that the test doesn't fail on developer machines with DE locale.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 77dee2bbd513db2ee89eb4882e02142f1fa619cd in wicket's branch refs/heads/master from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=77dee2b ]

          WICKET-6419 Localization of PageParameters

          Add some checks to be on the safe side.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 77dee2bbd513db2ee89eb4882e02142f1fa619cd in wicket's branch refs/heads/master from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=77dee2b ] WICKET-6419 Localization of PageParameters Add some checks to be on the safe side.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 04c96171e242d09fc34d4f93b1ca97f8fc61a67c in wicket's branch refs/heads/master from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=04c9617 ]

          Merge branch 'WICKET-6419'

          Show
          jira-bot ASF subversion and git services added a comment - Commit 04c96171e242d09fc34d4f93b1ca97f8fc61a67c in wicket's branch refs/heads/master from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=04c9617 ] Merge branch ' WICKET-6419 '

            People

            • Assignee:
              mgrigorov Martin Grigorov
              Reporter:
              Ravi Knox Ravi Knox
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development