[WICKET-6325] AbstractTree#updateBranch() and #updateNode() make AjaxRequestTarget mandatory

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 8.0.0-M3
• Fix Version/s: 8.0.0-M4
• Component/s: wicket-extensions
• Assignee: Sven Meier
• Reporter: Sven Meier
• Created: 23/Feb/17 14:34
• Updated: 23/Feb/17 14:36
• Resolved: 23/Feb/17 14:36

Description

With the new Optional<AjaxRequestTarget> spreading over Wickets code base, AbstractTree#updateBranch() and #updateNode() were changed (by me) to get an optional ART.

Further examination shows, that this was a wrong decision:

• most Java experts argue against optional method parameters
• there are cases now where an existing ART must be wrapped in an optional just to pass it into the methods.

The former solution to check the parameter against null isn't feasible now either, since you have to use optional#orElse(null) if you happen to have an Optional<ART> only.

Thus it is better to just make the ART parameter mandatory.