Wicket
  1. Wicket
  2. WICKET-623

Backport call to super onComponentTag in ExternalLink

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.7
    • Fix Version/s: 1.2.7
    • Component/s: wicket
    • Labels:
      None
    • Environment:
      Bug found in 1.2.6, fixed in trunk by jcompagner in rev 545131

      Description

      ExternalLink.setOutputMarkupId(true) has no effect.
      I could track this issue down to super.onComponentTag not being called at the end of ExternalLink's onComponentTag.

      Adding
      super.onComponentTag(tag);
      to the end of ExternalLink's onComponentTag would call Component's onComponentTag which in turn would add the markup id.

      Johan Compagner fixed this in trunk (rev 545131), but a backport for 1.2.7 would be nice.

        Activity

        Johannes Fahrenkrug created issue -
        Alastair Maw made changes -
        Field Original Value New Value
        Assignee Alastair Maw [ almaw ]
        Fix Version/s 1.2.7 [ 12312468 ]
        Hide
        Alastair Maw added a comment -

        Fixed in r546692.

        Show
        Alastair Maw added a comment - Fixed in r546692.
        Alastair Maw made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]

          People

          • Assignee:
            Alastair Maw
            Reporter:
            Johannes Fahrenkrug
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development