Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-6184

Remove form argument from AjaxButton and AjaxLink callbacks

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 8.0.0-M1
    • Fix Version/s: 8.0.0-M1
    • Component/s: wicket
    • Labels:
      None

      Description

      AjaxButton and AjaxLink supply the submitted form in their submit hooks, e.g.:

      protected void onSubmit(AjaxRequestTarget target, Form<?> form)
      

      The form is superfluous, since it is already available via #getForm().

      We decided to remove this parameter, bringing the hooks in line with the new static lambda factories, e.g.:

      public static AjaxSubmitLink onSubmit(String id, WicketBiConsumer<AjaxSubmitLink, AjaxRequestTarget> onSubmit)
      

      Relevant discussion: http://wicket-dev.markmail.org/thread/vzzntc6wbjub3fad

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit bd526717d566e542982689ae3fbfba6584072c24 in wicket's branch refs/heads/master from Sven Meier
        [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=bd52671 ]

        WICKET-6184 remove form argument from ajax hooks

        Show
        jira-bot ASF subversion and git services added a comment - Commit bd526717d566e542982689ae3fbfba6584072c24 in wicket's branch refs/heads/master from Sven Meier [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=bd52671 ] WICKET-6184 remove form argument from ajax hooks
        Hide
        svenmeier Sven Meier added a comment -

        AjaxButton, AjaxLink and AjaxFallbackButton hook methods are now without form argument.

        Show
        svenmeier Sven Meier added a comment - AjaxButton, AjaxLink and AjaxFallbackButton hook methods are now without form argument.

          People

          • Assignee:
            svenmeier Sven Meier
            Reporter:
            svenmeier Sven Meier
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development