[WICKET-6063] Add support for WebSocketRequest#getUrl() and other properties which are available in the handshake request

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.21.0
• Fix Version/s: 7.2.0, 8.0.0-M1, 6.22.0
• Component/s: wicket-native-websocket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Daniel Stoch
• Created: 04/Jan/16 13:47
• Updated: 15/Jan/16 12:24
• Resolved: 10/Jan/16 19:44

Description

During request processing some components can want to access some request parameters, paths, etc. When this is done during web socket request it can lead to IllegalArgumentExceptions, because WebSocketRequest.getUrl() method returns null.

java.lang.IllegalArgumentException: Argument 'url' may not be null.
    at org.apache.wicket.util.lang.Args.notNull(Args.java:41)
    at
org.apache.wicket.request.parameter.UrlRequestParametersAdapter.<init>(UrlRequestParametersAdapter.java:48)
    at
org.apache.wicket.request.Request.getQueryParameters(Request.java:128)
    at
org.apache.wicket.request.Request.getRequestParameters(Request.java:136)

Maybe these methods should better return empty Url instead of null (
return new Url(); )?