Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-5995

"Range" header parsing is broken

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 7.0.0
    • 7.1.0, 8.0.0-M1
    • wicket
    • None

    Description

      In the new version of Wicket, AbstractResource parses the 'Range' header in the method 'setRequestRangeMetaData'. This method is always called.

      Unfortunately, it is fundamentally broken. According to http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.35 a range request can contain multiple ranges. The current implementation only supports one range and throws a NumberFormatException when multiple ranges are requested.

      Fortunately, a Resource supporting Range requests can override this method, but it also means that the CONTENT_RANGE_STARTBYTE and CONTENT_RANGE_ENDBYTE metadata are a flawed abstraction.

      Attachments

        Activity

          People

            klopfdreh Tobias Soloschenko
            ntkoopman Tim Koopman
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: