Wicket
  1. Wicket
  2. WICKET-598

Support jetty continuations in wicket

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0.0-beta2
    • Component/s: wicket
    • Labels:
      None

      Description

      Using jetty continuations does not work on wicket.

      info about jetty continuations:
      http://docs.codehaus.org/display/JETTY/Continuations

      Calling jetty's

      continuation.suspend(timeout);

      will fail as it raises an RetryRequest exception that is caught by wicket.

      It should be let through instead so jetty server will be able to handle it.

      I am no continuations expert but letting through the exception seems to be enough to make this feature work and have a wonderful push model support inside wicket

      I will attach a patch that fixes the issue...

        Issue Links

          Activity

          Peter Ertl created issue -
          Peter Ertl made changes -
          Field Original Value New Value
          Attachment jetty-continuations.patch [ 12358485 ]
          Eelco Hillenius made changes -
          Assignee Eelco Hillenius [ ehillenius ]
          Hide
          Eelco Hillenius added a comment -

          I'm really not sure how to handle this in the best way. One thing you can see from your own patch, is that by providing your own RequestCycle (override logRuntimeException) and a custom request cycle processor (extend WebRequestCycleProcessor and override respond(RuntimeException, RequestCycle)).

          Show
          Eelco Hillenius added a comment - I'm really not sure how to handle this in the best way. One thing you can see from your own patch, is that by providing your own RequestCycle (override logRuntimeException) and a custom request cycle processor (extend WebRequestCycleProcessor and override respond(RuntimeException, RequestCycle)).
          Hide
          Jonathan Locke added a comment -

          This is an RFE. We're feature frozen. Shouldn't we kick this to next version?

          Show
          Jonathan Locke added a comment - This is an RFE. We're feature frozen. Shouldn't we kick this to next version?
          Alastair Maw made changes -
          Fix Version/s 1.4.0-alpha [ 12312523 ]
          Frank Bille Jensen made changes -
          Link This issue relates to WICKET-363 [ WICKET-363 ]
          Martijn Dashorst made changes -
          Fix Version/s 1.4-M1 [ 12312523 ]
          Fix Version/s 1.5-M1 [ 12313078 ]
          Eelco Hillenius made changes -
          Assignee Eelco Hillenius [ ehillenius ]
          Igor Vaynberg made changes -
          Fix Version/s 1.5-M2 [ 12315237 ]
          Fix Version/s 1.5-M1 [ 12313078 ]
          Igor Vaynberg made changes -
          Fix Version/s 1.5-M3 [ 12315329 ]
          Fix Version/s 1.5-M2 [ 12315237 ]
          Jeremy Thomerson made changes -
          Fix Version/s 1.5-M4 [ 12315483 ]
          Fix Version/s 1.5-M3 [ 12315329 ]
          Martin Grigorov made changes -
          Fix Version/s 1.5-M4 [ 12315483 ]
          Martijn Dashorst made changes -
          Assignee Emond Papegaaij [ papegaaij ]
          Hide
          Emond Papegaaij added a comment -

          Wicket 6 now features an experimental module that integrates the Atmosphere framework (wicket-atmosphere). With this module, ajax updates can be pushed to the client. All major browsers and webservers are supported, including jetty. This makes this feature request obsolete.

          Show
          Emond Papegaaij added a comment - Wicket 6 now features an experimental module that integrates the Atmosphere framework (wicket-atmosphere). With this module, ajax updates can be pushed to the client. All major browsers and webservers are supported, including jetty. This makes this feature request obsolete.
          Emond Papegaaij made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 6.0.0-RC1 [ 12320343 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              Emond Papegaaij
              Reporter:
              Peter Ertl
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development