Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-5717

Url.parse/toString should support fragment

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.17.0
    • Fix Version/s: 6.18.0, 7.0.0-M4
    • Component/s: wicket
    • Labels:
      None

      Description

      Hi,

      Starting with Wicket 6.16, we have issues redirecting to an absolute
      URL containing a fragment: the # is escaped by Wicket.

      Changes in the commit
      https://fisheye6.atlassian.com/changelog/wicket-git?cs=e1f29e90ff3a35e117bb3ddc5ee2aefd900c13c8
      are causing the regression but as far as we can see, the commit is not
      the problem: the issue is that Url.parse then toString encodes the
      anchor.

      Before this commit, as we were using an absolute Url, we were in the
      case where the Url wasn't escaped.

      We think the right fix would be to make org.apache.wicket.request.Url
      anchor aware.

      Pull request to come.

        Attachments

        1. redirect-url-anchor.tar.gz
          27 kB
          Guillaume Smet

          Issue Links

            Activity

              People

              • Assignee:
                mgrigorov Martin Tzvetanov Grigorov
                Reporter:
                gsmet Guillaume Smet
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: