Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-5672

Form#findSubmittingComponent() should not throw exceptions if the submitter is disabled/invisible

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 7.0.0-M2
    • 7.0.0-M3
    • wicket
    • None

    Description

      As explained by a user at http://markmail.org/message/s262q4yc3ubymglr it is unexpected that org.apache.wicket.markup.html.form.Form#findSubmittingButton() throws runtime exceptions when the submitter is invisible or disabled.

      As discussed at http://markmail.org/message/qhjepkihr27uywaj the checks should be moved to the code related to executing the submitter's action method (i.e. onSubmit()) and leave all other users of Form#findSubmittingButton() decide for themselves whether the change of the visiblility/enable state is a problem of not.

      Attachments

        Activity

          People

            mgrigorov Martin Tzvetanov Grigorov
            mgrigorov Martin Tzvetanov Grigorov
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: