Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-5648

CookieUtils - multivalue related methods are broken due to the usage of ";" as a separator for the values

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 7.0.0-M3, 6.17.0
    • None
    • None

    Description

      Hi, not sure even whether CookieUtils is supposed to be used outside wicket. But if so, it has some API flaws.

      The CookieUtils class has

      public final void save(String key, final String... values)

      but no public load method to load the saved multiple values. Clients can load the whole string and split themselves, but that's dirty. And using FormComponent.VALUE_SEPARATOR seems wicket-specific anyway (and is not safe against values with that separator), so maybe that method should be protected, not public.

      The code

      cookie.setSecure(false);

      in save() also seems dodgy, but seems to have no effect (defaultSettings still work).

      Finally it is a bit weird that there is no access to the underlying Cookie itself, with it's getDomain() etc methods. For Developers it might be nice to work with the cookie avoiding the boilerplate code, so maybe getCookie() could be made public instead of private

      Attachments

        Issue Links

          Activity

            People

              mgrigorov Martin Tzvetanov Grigorov
              tkruse Thibault Kruse
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: