Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-5642

CheckingOutputObjectStream should filter duplicates by identity, not by equality

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.16.0
    • Fix Version/s: 7.0.0-M3, 6.17.0
    • Component/s: wicket
    • Labels:
      None

      Description

      As discussed at http://markmail.org/message/kdbyimrznubgtz5n the checks for duplicates by equality is not correct (and optimal).

      CheckingOOS already filters checked objects by identity (see org.apache.wicket.core.util.objects.checker.CheckingObjectOutputStream#checked) so there is no need to check second time (via Stack#equals()).

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mgrigorov Martin Tzvetanov Grigorov
                Reporter:
                mgrigorov Martin Tzvetanov Grigorov
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: