[WICKET-5557] Don't cache the result of AuthenticatedWebApplication#getWebSessionClass()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.14.0
• Fix Version/s: 7.0.0-M1, 6.15.0
• Component/s: wicket-auth-roles
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Bill Speirs
• Created: 10/Apr/14 20:13
• Updated: 14/Apr/14 08:34
• Resolved: 14/Apr/14 08:34

Description

Currently the AuthenticatedWebApplication constructor obtains and holds a reference to the AbstractAuthenticatedWebSession class. This makes it impossible for classes extending AuthenticatedWebApplication to use a class based upon something passed into their constructors. The only option is to provide a "static"/"constant" class from the getWebSessionClass() method.

I don't see any advantage to holding this reference. Instead I propose that the class is changed to simply calling getWebSessionClass() each time the class is needed.