[WICKET-5518] FormComponent.updateCollectionModel does not handle unmodifiableList

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.12.0
• Fix Version/s: 7.0.0-M1, 6.15.0
• Assignee: Sven Meier
• Reporter: Petr Lancaric
• Created: 25/Feb/14 11:57
• Updated: 27/Feb/14 10:57
• Resolved: 27/Feb/14 10:57

Description

FormComponent.updateCollectionModel should handle situation, when getter returns unmodifiable list.

Proposed solution:

formComponent.modelChanging();
booelan isChanged;
try {
collection.clear();
if (convertedInput != null)

{ collection.addAll(convertedInput); }

isChanged = true;
catch (Exception e)

{ // ignore this exception as Unmodifiable list does not allow change logger.info("An error occurred while trying to modify list attached to " + formComponent, e); }

try

{ if(isChanged) formComponent.getModel().setObject(collection); else // TODO: create here collection as non-abstract successor of setObject declared argument formComponent.getModel().setObject(new ArrayList(convertedInput)); isChanged = true; }

catch (Exception e)

{ // ignore this exception because it could be that there // is not setter for this collection. logger.info("An error occurred while trying to set the new value for the property attached to " + formComponent, e); }

// at least one update method should pass successfully
if(isChanged)
formComponent.modelChanged();
else
throw new RuntimeException("An error occurred while trying to modify value for the property attached to " + formComponent);