Wicket
  1. Wicket
  2. WICKET-540

ServletWebRequest.getContextPath() ignores ContextPath as set by user (accesses HttpServletRequest directly)

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.2.5
    • Fix Version/s: 1.2.7
    • Component/s: wicket
    • Labels:
      None

      Description

      I'm running Wicket behind a front-end proxy. To fix certain issues with this I have set the ContextPath value in my application settings (and/or in Web.xml), However, when using functions that attempt to get at the context path (e.g. continueToOriginalDestination()) the app does not respect my setting.

      This is because in ServletWebRequest, getContextPath() directly accesses HttpServletRequest without checking the application settings.

      I believe it should first check the application settings, and only if ContextPath is /not/ set, then access the HttpServletRequest.

        Activity

        Alastair Maw made changes -
        Resolution Fixed [ 1 ]
        Fix Version/s 1.2.7 [ 12312468 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Alastair Maw made changes -
        Assignee Alastair Maw [ almaw ]
        Jean-Baptiste Quenot made changes -
        Assignee Jean-Baptiste Quenot [ jbq ]
        Jean-Baptiste Quenot made changes -
        Field Original Value New Value
        Assignee Jean-Baptiste Quenot [ jbq ]
        Seth Green created issue -

          People

          • Assignee:
            Alastair Maw
            Reporter:
            Seth Green
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development