[WICKET-5390] Session management doesn't work with Jetty's JDBCSessionManager

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.11.0
• Fix Version/s: 6.12.0, 7.0.0-M1
• Component/s: wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Christoph Leiter
• Created: 18/Oct/13 13:43
• Updated: 17/Jan/14 09:39
• Resolved: 29/Oct/13 13:16

Description

I use JDBCSessionIdManager/JDBCSessionManager from Jetty to store my sessions in a DB. Jetty tries to be smart and determines if a session is dirty and only persists it then. The logic is that a call to HttpSession#setAttribute may cause the dirty flag to be set if A) the value is new OR B) the value is changed, i.e. not #equals to the previous value. Wicket stores a PageStoreManager$SessionEntry as an attribute. This class doesn't have a specific equals implementation and so from the Jetty point of view the session never changes. The effect is that after Jetty restores the session from the DB it will be always in the initial state.

One possible fix is to always return false in SessionEntry#equals. But I'm not sure what Jetty is doing here is correct either.

Issue Links

• is broken by: WICKET-5380 Wicket rebinds the SessionEntry session attribute and this causes problems in Glassfish
• is superceded by: WICKET-5473 Wicket does not handle non in-memory Httpsessions correctly