Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-5375

Improve ConcatBundleResource error handling when a resource is missing

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.11.0
    • Fix Version/s: 6.12.0, 7.0.0-M1
    • Component/s: wicket
    • Labels:
      None

      Description

      If a resource bundle cannot find any of its items them it fails with:

      Caused by: java.lang.NullPointerException
      at org.apache.wicket.resource.bundles.ConcatBundleResource.readAllResources(ConcatBundleResource.java:172)
      at org.apache.wicket.resource.bundles.ConcatBundleResource.getCacheableResourceStream(ConcatBundleResource.java:229)
      at org.apache.wicket.request.resource.caching.version.LastModifiedResourceVersion.getVersion(LastModifiedResourceVersion.java:41)
      at org.apache.wicket.request.resource.caching.version.RequestCycleCachedResourceVersion.getVersion(RequestCycleCachedResourceVersion.java:97)
      at org.apache.wicket.request.resource.caching.FilenameWithVersionResourceCachingStrategy.decorateUrl(FilenameWithVersionResourceCachingStrategy.java:102)
      at org.apache.wicket.core.request.mapper.BasicResourceReferenceMapper.mapHandler(BasicResourceReferenceMapper.java:238)
      at org.apache.wicket.request.mapper.ParentPathReferenceRewriter.mapHandler(ParentPathReferenceRewriter.java:91)
      at org.apache.wicket.request.mapper.CompoundRequestMapper.mapHandler(CompoundRequestMapper.java:215)
      at org.apache.wicket.request.cycle.RequestCycle.mapUrlFor(RequestCycle.java:433)

      Both org.apache.wicket.resource.bundles.ConcatBundleResource#collectResourceStreams and org.apache.wicket.resource.bundles.ConcatBundleResource#getCacheKey return null if any of the resources' streams cannot be loaded.

      It would be nice if Wicket logs an error explaining which resource is missing.

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            mgrigorov Martin Grigorov
            Reporter:
            mgrigorov Martin Grigorov
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development