Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-5350

Enhancement for AbstractChoice and WildcardListModel API

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.10.0, 7.0.0-M1
    • Fix Version/s: 7.0.0-M4
    • Component/s: None
    • Labels:

      Description

      According to Efective Java book (http://devender.files.wordpress.com/2008/05/effectivejava.pdf), item 28:

      "No wildcard type for return value"

      Especially "User should not have to think about wildcards to use your API".

      so

      public List<? extends E> getChoices()

      should be changed to

      public List<E> getChoices()

      and for WildcardListModel

      protected List<? extends T> createSerializableVersionOf(List<? extends T> object)

      should be changed to

      protected List<T> createSerializableVersionOf(List<? extends T> object)

      Probably there is a lot of such things in framework.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                svenmeier Sven Meier
                Reporter:
                betlista Betlista
              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: