[WICKET-5203] Base url is incorrect for error dispatched pages

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.8.0
• Fix Version/s: 6.9.0, 1.5.11, 7.0.0-M1
• Component/s: wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Martin Tzvetanov Grigorov
• Created: 24/May/13 14:54
• Updated: 31/Jul/13 12:03
• Resolved: 27/May/13 08:35

Description

The fix for https://issues.apache.org/jira/browse/WICKET-4387 includes the following code in org.apache.wicket.protocol.http.servlet.ServletWebRequest#ServletWebRequest(HttpServletRequest httpServletRequest, String filterPrefix, Url url):

if (forwardAttributes != null || errorAttributes != null)
{
if (LOG.isDebugEnabled())
{
LOG.debug("Setting filterPrefix('{}') to '' because there is either an error or a forward. {}, {}",
new Object[]

{filterPrefix, forwardAttributes, errorAttributes}

);
}
// the filter prefix is not needed when the current request is internal
// see WICKET-4387
this.filterPrefix = "";

The filterPrefix is actually needed later when a request is made due to an error (e.g. 404):

public Url getClientUrl()
{
if (errorAttributes != null && !Strings.isEmpty(errorAttributes.getRequestUri()))
{
String problematicURI = Url.parse(errorAttributes.getRequestUri(), getCharset())
.toString();
return getContextRelativeUrl(problematicURI, filterPrefix);

With filterPrefix=="" the urls for any resources in the error page are wrong.

Issue Links

• is broken by: WICKET-4387 StringIndexOutOfBoundsException when forwarding requests
• is related to: WICKET-5018 redirectToInterceptPage results in 404 when url-rewriting is active