Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-5166

Relax the requirements for using FilteringHeaderResponse

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.7.0
    • Fix Version/s: 6.8.0, 7.0.0-M1
    • Component/s: wicket
    • Labels:
      None

      Description

      I see two improvements to FilteringHeaderResponse:

      1) FilteringHeaderResponse requires a name for the filter that should be used for contributions in the <head>. Since the value of this filter name is custom FilteringHeaderResponse can provide constructor which provides default name for this filter

      2) If a HeaderItem is not accepted by any of the configured filters then the item is simply dropped and a warning message is logged. It will be much more friendlier if the item is rendered in the <head> as in the case when non-filtering header response is used. The application should not be forced to provide filter for this explicitly.

        Attachments

          Activity

            People

            • Assignee:
              mgrigorov Martin Grigorov
              Reporter:
              mgrigorov Martin Grigorov
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: