Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 6.6.0
    • Fix Version/s: 6.7.0
    • Component/s: wicket
    • Labels:
      None

      Description

      Properties files containing translations miss some entries in French (or miss french files)

      1. fix-WICKET-5139.patch
        8 kB
        Cedric Gatay
      2. fix-WICKET-5139_xml.patch
        19 kB
        Cedric Gatay

        Activity

        Cedric Gatay created issue -
        Hide
        Cedric Gatay added a comment -

        Attached updated translations regarding master branch.

        Show
        Cedric Gatay added a comment - Attached updated translations regarding master branch.
        Cedric Gatay made changes -
        Field Original Value New Value
        Attachment fix-WICKET-5139.patch [ 12577788 ]
        Hide
        Martin Grigorov added a comment -

        I think it is a good time to rework all .properties files to .properties.xml.
        This way there wont be the need to use Unicode escapes like \u00eatre.
        Do you want to do it ?
        If you have no time then we will apply the attach patch as is.
        Thanks!

        Show
        Martin Grigorov added a comment - I think it is a good time to rework all .properties files to .properties.xml. This way there wont be the need to use Unicode escapes like \u00eatre. Do you want to do it ? If you have no time then we will apply the attach patch as is. Thanks!
        Hide
        Cedric Gatay added a comment -

        I will have a look at doing a small Groovy script doing the job, please keep in mind that if I run the script on all the .properties file it will require a somewhat huge code review (I can also run it only on _fr and basic files to lower the reviewing work).

        I think this patch can be applied and a task (which I'm disposed to take) could be added into Wicket.next (or at least 6.x+2) consisting in migrating to .properties.xml. What do you think of this ?

        Show
        Cedric Gatay added a comment - I will have a look at doing a small Groovy script doing the job, please keep in mind that if I run the script on all the .properties file it will require a somewhat huge code review (I can also run it only on _fr and basic files to lower the reviewing work). I think this patch can be applied and a task (which I'm disposed to take) could be added into Wicket.next (or at least 6.x+2) consisting in migrating to .properties.xml. What do you think of this ?
        Hide
        Martin Grigorov added a comment -

        I meant only the FR translations.
        I guess you like me do not know Chinese or Hungarian so we wont touch them

        Show
        Martin Grigorov added a comment - I meant only the FR translations. I guess you like me do not know Chinese or Hungarian so we wont touch them
        Hide
        Cedric Gatay added a comment -

        In this case I think I can do this very soon

        Show
        Cedric Gatay added a comment - In this case I think I can do this very soon
        Hide
        Cedric Gatay added a comment -

        Xml version of french properties files. The previous patch can be ignored as the diff of this one has been made without.
        The small groovy script that I used is available at the following url (just in case it could help future properties to properties.xml updates) : https://github.com/CedricGatay/small-scripts/blob/master/groovy/PropertyFilesToXMLOnes.groovy

        Show
        Cedric Gatay added a comment - Xml version of french properties files. The previous patch can be ignored as the diff of this one has been made without. The small groovy script that I used is available at the following url (just in case it could help future properties to properties.xml updates) : https://github.com/CedricGatay/small-scripts/blob/master/groovy/PropertyFilesToXMLOnes.groovy
        Cedric Gatay made changes -
        Attachment fix-WICKET-5139_xml.patch [ 12577816 ]
        Hide
        Martin Grigorov added a comment -

        Merci beaucoup, Cedric!

        Show
        Martin Grigorov added a comment - Merci beaucoup, Cedric!
        Martin Grigorov made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Martin Grigorov [ mgrigorov ]
        Fix Version/s 6.7.0 [ 12323964 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Cedric Gatay
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.5h
              0.5h
              Remaining:
              Remaining Estimate - 0.5h
              0.5h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development