[WICKET-5124] Improve ResourceReference#getDependencies() API

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.6.0
• Fix Version/s: 7.0.0-M1
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Igor Vaynberg
• Created: 29/Mar/13 00:11
• Updated: 22/Apr/15 16:50
• Resolved: 03/May/13 13:16

Description

currently the signature is

public Iterable<? extends HeaderItem> getDependencies()

which is awkward to use.

suppose i want a javascript reference that should include a css reference as a dependency, i cannot simply add it to iterable like this:

new ResourceReference(Some.class, "some.js") {
Iterable getDependencies() {
Iterable supers=super.getDependencies();
// supers.add(CSS); <=== cannot do this, instead
List list=new ArrayList();
for (reference:supers)

{ list.add(reference); }

// now i can finally add mine
list.add(CSS);
return list;
}
}

instead change Iterable to a List that is backed by a mutable one. this should make extending much easier. if List is too "open" create Appendable

{ append(); }

backed by a list and use that.