Wicket
  1. Wicket
  2. WICKET-5080

FilterToolbar.html contains javascript that is used elsewhere

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 6.6.0
    • Fix Version/s: 6.7.0
    • Component/s: wicket-extensions
    • Labels:
      None

      Description

      The file FilterToolbar.html has some JavaScript included. This is inconvenient as we have written our own FilterToolbar with its own markup and still need the JavaScript. So I propose to externalize the JavaScript as a ResourceReference. I have included a patch as a proposal.

        Activity

        Hide
        Sven Meier added a comment -

        I've left FilterForm#JS private, since this is what most other JavaScript components in wicket do. If you need the js file, you can easily reuse it with your own ResourceReference.

        Show
        Sven Meier added a comment - I've left FilterForm#JS private, since this is what most other JavaScript components in wicket do. If you need the js file, you can easily reuse it with your own ResourceReference.
        Sven Meier made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Sven Meier [ svenmeier ]
        Fix Version/s 6.7.0 [ 12323964 ]
        Resolution Fixed [ 1 ]
        Hide
        Sven Meier added a comment -

        focus handling is now moved to FilterForm.

        Show
        Sven Meier added a comment - focus handling is now moved to FilterForm.
        Oleg Galimov made changes -
        Field Original Value New Value
        Attachment 0001-patch.patch [ 12572321 ]
        Oleg Galimov created issue -

          People

          • Assignee:
            Sven Meier
            Reporter:
            Oleg Galimov
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development