Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-5080

FilterToolbar.html contains javascript that is used elsewhere

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.6.0
    • Fix Version/s: 6.7.0
    • Component/s: wicket-extensions
    • Labels:
      None

      Description

      The file FilterToolbar.html has some JavaScript included. This is inconvenient as we have written our own FilterToolbar with its own markup and still need the JavaScript. So I propose to externalize the JavaScript as a ResourceReference. I have included a patch as a proposal.

        Activity

        Hide
        svenmeier Sven Meier added a comment -

        I've left FilterForm#JS private, since this is what most other JavaScript components in wicket do. If you need the js file, you can easily reuse it with your own ResourceReference.

        Show
        svenmeier Sven Meier added a comment - I've left FilterForm#JS private, since this is what most other JavaScript components in wicket do. If you need the js file, you can easily reuse it with your own ResourceReference.
        Hide
        svenmeier Sven Meier added a comment -

        focus handling is now moved to FilterForm.

        Show
        svenmeier Sven Meier added a comment - focus handling is now moved to FilterForm.

          People

          • Assignee:
            svenmeier Sven Meier
            Reporter:
            ogalimov Oleg Galimov
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development