[WICKET-5039] Manual invocation of FunctionsExecutor#notify() is broken

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 6.4.0
• Fix Version/s: 6.7.0
• Component/s: wicket
• Environment: any
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Ernesto Reinaldo Barreiro
• Created: 13/Feb/13 12:27
• Updated: 20/Jun/13 07:52
• Resolved: 21/Feb/13 14:20

Description

We are having problems on Wicket 1.4.x with and "AJAX function" processEvaluation... and I see the code is practically the same at 6.x. So, let's bring the subject to the list...

Our problem is that after evaluating some expressions with errors, screen "freezes" because post-call handlers are not called. Problem seems to be related to the code.

// test if the javascript is in form of identifier|code
// if it is, we allow for letting the javascript decide when the rest of processing will continue
// by invoking identifier();
var res = text.match(new RegExp("^([a-z|A-Z_][a-z|A-Z|0-9_])\\|((.|
n))$"));

if (res !== null) {
var f = jQuery.noop;
text = "f = function(" + res[1] + ")

{" + res[2] + "}

;";

try

{ // do the evaluation eval(text); f(notify); } catch (exception) { Wicket.Log.error("Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: " + exception + ", text: " + text); }

}


In case of error. Shouldn't it be

try { // do the evaluation eval(text); f(notify); }

catch (exception)

{ Wicket.Log.error("Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: " + exception + ", text: " + text); notify(); }

So that next steps in processing get called. The above solves or freezing problem in case of error

Issue Links

• is broken by: WICKET-4881 IE 8 : error when handling Wicket Ajax Response
• is related to: WICKET-5243 JS: High stack size in Function Executor causes "too much recursion"