Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-5019

Handling of NO_MINIFIED_NAME in PackageResourceReference#internalGetMinifiedName()

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 6.5.0
    • 6.6.0
    • wicket
    • None

    Description

      The Value NO_MINIFIED_NAME is not handled correctly as entry in the MINIFIED_NAMES_CACHE in PackageResourceReference#internalGetMinifiedName()

      private String internalGetMinifiedName()
      {
      String minifiedName = MINIFIED_NAMES_CACHE.get(this);
      if (minifiedName != null && minifiedName != NO_MINIFIED_NAME)

      { ^^^^^^^ return minifiedName; }

      ...

      You should remove the condition "minifiedName != NO_MINIFIED_NAME" here to leverage the
      MINIFIED_NAMES_CACHE for NO_MINIFIED_NAME cache entries. Otherwise you always run into the resource resolving code if there is no minified resource.

      Attachments

        Activity

          People

            svenmeier Sven Meier
            rfoerthe Roland Foerther
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: