Wicket
  1. Wicket
  2. WICKET-5019

Handling of NO_MINIFIED_NAME in PackageResourceReference#internalGetMinifiedName()

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 6.5.0
    • Fix Version/s: 6.6.0
    • Component/s: wicket
    • Labels:
      None

      Description

      The Value NO_MINIFIED_NAME is not handled correctly as entry in the MINIFIED_NAMES_CACHE in PackageResourceReference#internalGetMinifiedName()

      private String internalGetMinifiedName()
      {
      String minifiedName = MINIFIED_NAMES_CACHE.get(this);
      if (minifiedName != null && minifiedName != NO_MINIFIED_NAME)

      { ^^^^^^^ return minifiedName; }

      ...

      You should remove the condition "minifiedName != NO_MINIFIED_NAME" here to leverage the
      MINIFIED_NAMES_CACHE for NO_MINIFIED_NAME cache entries. Otherwise you always run into the resource resolving code if there is no minified resource.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        7h 16m 1 Sven Meier 31/Jan/13 20:45
        Sven Meier made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Sven Meier [ svenmeier ]
        Fix Version/s 6.6.0 [ 12323963 ]
        Resolution Fixed [ 1 ]
        Hide
        Sven Meier added a comment -

        Thanks.

        Show
        Sven Meier added a comment - Thanks.
        Roland Foerther created issue -

          People

          • Assignee:
            Sven Meier
            Reporter:
            Roland Foerther
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development