Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4966

Remove outdated BoxBorder

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 6.2.0
    • 7.0.0-M1
    • wicket
    • None

    Description

      Just stubled upon BoxBorder, which is "A very simple border component that draws a thin black line around its children." and creates markup like this:

      <table width = "0%" border = "0" cellspacing = "0" cellpadding = "1" bgcolor = "black">
      <tr>
      <td width = "100%" valign = "top">
      <table width = "100%" border = "0" cellspacing = "0" cellpadding = "4" bgcolor = "white">
      <tr>
      <td width = "100%">
      <wicket:body/>
      </td>
      </tr>
      </table>
      </td>
      </tr>
      </table>

      I know, no one is forced to use it... but honestly: no developer should be lead to the assumption that creating a border like this is a good idea.

      I suggest to deprecate it, or otherwise move it to wicket-extension or somewhere else.

      Attachments

        Activity

          People

            mgrigorov Martin Tzvetanov Grigorov
            pparson Peter Parson
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: