Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4964

Rename Component#renderHead(HtmlHeaderContainer)

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.4.0
    • Fix Version/s: 7.0.0-M1
    • Component/s: wicket
    • Labels:
      None

      Description

      It seems it happens somewhat often that users mistakenly override renderHead(HtmlHeaderContainer) rather than renderHead(IHeaderResponse). Code completion makes this a very easy mistake.

      I propose renaming the somewhat-internal method renderHead(HtmlHeaderContainer) to renderIntoPageHeaderContainer or something like that. We can't just make the method package private, since it is needed by Panel, Border and FormComponentPanel to render the header sections of their associated markup.

        Attachments

          Activity

            People

            • Assignee:
              mgrigorov Martin Tzvetanov Grigorov
              Reporter:
              cmenzel Carl-Eric Menzel
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: