Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4950

ResourceStreamLocator#newResourceNameIterator isn't a factory method anymore

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 6.4.0
    • 6.5.0
    • wicket
    • None

    Description

      During migration from wicket 1.5 to 6 I noticed that ResourceStreamLocator and ResourceNameIterator changed in some ways.

      IMO suboptimal: the method ResourceStreamLocator#newResourceNameIterator contains code. Typically all new... methods only create a new instance, so user can override and add his own implementation.

      Since the parameter 'extension' (from ResourceNameIterator) changed from String to Iterator<String>, I suggest to provide a 'newResourceNameIterator' method with a Iterator as parameter (only creating a new ResourceNameIterator).

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mgrigorov Martin Tzvetanov Grigorov
            manthos manthos
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment