Wicket
  1. Wicket
  2. WICKET-4922

Cloned ServletWebRequest returns wrong OriginalUrl

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 6.3.0
    • Fix Version/s: 6.4.0, 1.5.10
    • Component/s: wicket
    • Labels:
      None

      Description

      ServletWebRequest, when cloned with a new URL, return the incorrect URL from getOriginalUrl(). This presents itself as a problem when using redirect to intercept page in conjunction with a root request mapper that modifies the URL passed to the wrapped request mapper. (incidentally, this does not affect CryptoMapper, since CryptoMapper tries passing both the decrypted and the original, supposedly encrypted, URL to the wrapped request mapper). I have my own path modifying request mapper that is getting affected by this.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1h 38m 1 Martin Grigorov 12/Dec/12 13:12
        Martin Grigorov made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Martin Grigorov [ mgrigorov ]
        Fix Version/s 6.4.0 [ 12323450 ]
        Fix Version/s 1.5.10 [ 12323510 ]
        Resolution Fixed [ 1 ]
        Jesse Long made changes -
        Field Original Value New Value
        Attachment WICKET-4922.patch [ 12560544 ]
        Hide
        Jesse Long added a comment -

        WICKET-4922.patch - A patch to solve the solution. I also override the getOriginalUrl() method in WebRequest as a reminder to future subclassers of WebRequest that the cloneWithUrl() method needs to preserve the getOriginalUrl() functionality.

        Show
        Jesse Long added a comment - WICKET-4922 .patch - A patch to solve the solution. I also override the getOriginalUrl() method in WebRequest as a reminder to future subclassers of WebRequest that the cloneWithUrl() method needs to preserve the getOriginalUrl() functionality.
        Jesse Long created issue -

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Jesse Long
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development