Wicket
  1. Wicket
  2. WICKET-4891

UrlRenderer.renderRelativeUrl misbehavior if the filterPath is composed.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 6.3.0
    • Fix Version/s: 6.4.0
    • Component/s: wicket
    • Labels:
      None

      Description

      Using an application with a composed filterPath like:

      <filter-mapping>
      <filter-name>wicket.jsessionid</filter-name>
      <url-pattern>/demo/test/*</url-pattern>
      </filter-mapping>

      Wicket fails to properly render a bookmarkable link.

      I've debuged my app and the problem is here:

      UrlRenderer.removeCommonPrefixes()
      Line 309:

      String filterPath = request.getFilterPath();
      if (filterPath != null && segments.isEmpty() == false)
      {
      if (filterPath.equals(UrlUtils.normalizePath(segments.get(0))))
      {
      LOG.debug("Removing the filter path '{}' from '{}'", filterPath, segments);
      segments.remove(0);
      }
      }

      This code assumes that the filter path is a single segment path, not a composed path.

      I've only reached this bug browsing my website with the cookies disable. This is why it's not critical.

      1. WICKET-4891.patch
        13 kB
        Jordi Deu-Pons
      2. WICKET-4891.tar.gz
        19 kB
        Jordi Deu-Pons

        Activity

        Sven Meier made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Sven Meier [ svenmeier ]
        Fix Version/s 6.4.0 [ 12323450 ]
        Resolution Fixed [ 1 ]
        Jordi Deu-Pons made changes -
        Attachment WICKET-4891.patch [ 12554883 ]
        Jordi Deu-Pons made changes -
        Field Original Value New Value
        Attachment WICKET-4891.tar.gz [ 12554868 ]
        Jordi Deu-Pons created issue -

          People

          • Assignee:
            Sven Meier
            Reporter:
            Jordi Deu-Pons
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development