Wicket
  1. Wicket
  2. WICKET-4861

Making MultiFileUploadField use HTML5 multiple attr & remove confusing fakepath

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 6.2.0
    • Fix Version/s: 6.6.0
    • Component/s: wicket
    • Labels:
      None

      Description

      WICKET-3370 prepared the terrain (all major browsers except IE already support it).
      I will make a Git pull request for getting this into the master branch.
      Here is what the changes do (commit comment):

      Added the possibility to select multiple files in the OS dialog for
      browsers that support HTML5 'multiple' attribute. For browsers that do
      not support it, or if you do not set the boolean to true, it will behave
      the same as before.
      New:

      • easier select multiple files from multiple folders
      • shows the multiple files after choosing them - one per line
        Fixes:
      • the delete buttons are aligned instead of positioning after the
        variable length file names
      • useless and confusing "C:\fakepath" in filenames reported by some
        browsers (in multiple with single select mode) are now hidden.
      1. fix-WICKET-4861.patch
        8 kB
        Andrei Costescu
      2. test1.zip
        25 kB
        Andrei Costescu

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          90d 20h 14m 1 Martin Grigorov 07/Feb/13 12:18
          Hide
          ASF GitHub Bot added a comment -

          Github user costescuandrei closed the pull request at:

          https://github.com/apache/wicket/pull/20

          Show
          ASF GitHub Bot added a comment - Github user costescuandrei closed the pull request at: https://github.com/apache/wicket/pull/20
          Gavin made changes -
          Link This issue relates to WICKET-3370 [ WICKET-3370 ]
          Gavin made changes -
          Link This issue relates to WICKET-3370 [ WICKET-3370 ]
          Martin Grigorov made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Martin Grigorov [ mgrigorov ]
          Resolution Fixed [ 1 ]
          Martin Grigorov made changes -
          Fix Version/s 6.6.0 [ 12323963 ]
          Andrei Costescu made changes -
          Attachment fix-WICKET-4861.patch [ 12553650 ]
          Hide
          Andrei Costescu added a comment -

          Here's the patch. What should I do with the github pull request?

          Show
          Andrei Costescu added a comment - Here's the patch. What should I do with the github pull request?
          Hide
          Martin Grigorov added a comment -

          Right. GitHub is just a mirror of Apache's Git/SVN servers.

          Show
          Martin Grigorov added a comment - Right. GitHub is just a mirror of Apache's Git/SVN servers.
          Hide
          Andrei Costescu added a comment -

          I guess it has to be a patch, cause github is not apache...

          Show
          Andrei Costescu added a comment - I guess it has to be a patch, cause github is not apache...
          Hide
          Andrei Costescu added a comment -

          Is a pull request enough or does it have to be patch?
          https://github.com/apache/wicket/pull/20

          Show
          Andrei Costescu added a comment - Is a pull request enough or does it have to be patch? https://github.com/apache/wicket/pull/20
          Hide
          Martin Grigorov added a comment -

          Please attach the changes here as a patch.
          This way you officially give permissions to Apache to use your code.
          Thanks!

          Show
          Martin Grigorov added a comment - Please attach the changes here as a patch. This way you officially give permissions to Apache to use your code. Thanks!
          Andrei Costescu made changes -
          Attachment test1.zip [ 12552783 ]
          Hide
          Andrei Costescu added a comment -

          A quick test project is attached.

          Show
          Andrei Costescu added a comment - A quick test project is attached.
          Andrei Costescu made changes -
          Field Original Value New Value
          Link This issue relates WICKET-3370 [ WICKET-3370 ]
          Andrei Costescu created issue -

            People

            • Assignee:
              Martin Grigorov
              Reporter:
              Andrei Costescu
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development